fix(ci): fix zizmor pedantic check failures#16544
Merged
Merged
Conversation
…check zizmor flags dtolnay/rust-toolchain as superfluous-actions because ubuntu-latest runners already include rustup and cargo. Replace the action with a simple `rustup default stable` run step.
Rename spec-review.yml → spec-review.disabled so zizmor no longer scans it. The reusable workflow has secrets-outside-env warnings that cannot be trivially fixed — the secrets are required by workflow_call jobs and there’s no way to use a dedicated environment with reusable workflow secrets. Disabling the file until we have a real fix.
christopherco
force-pushed
the
chrco/fix-ci-zizmor
branch
from
304eb2a to
8eebf66
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix failing zizmor “pedantic” CI checks by removing a flagged superfluous Rust toolchain setup step and by disabling the spec review reusable workflow that triggers hard-to-fix zizmor findings.
Changes:
- Replaced
dtolnay/rust-toolchainusage in the zizmor-check workflow with an inlinerustup default stablestep. - Added/renamed the reusable spec review workflow to
spec-review.disabledto prevent it from being picked up by workflow tooling/scanning.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/check-workflows.yml | Removes a zizmor-flagged action by using inline rustup before installing/running zizmor. |
| .github/workflows/spec-review.disabled | Disables the reusable spec-review workflow by moving it to a non-.yml filename. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reubeno
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the zizmor CI check that's currently failing on PRs.
Changes
Commit 1: Replace
dtolnay/rust-toolchainwith inlinerustupin check-workflows.ymlzizmor flags
dtolnay/rust-toolchainassuperfluous-actionsbecause ubuntu-latest runners already includerustupandcargo. Replace the action with a simplerustup default stablerun step.Commit 2: Rename
spec-review.yml→spec-review.disabledto disable the workflowThe reusable workflow has
secrets-outside-envwarnings that cannot be trivially fixed — the secrets are required byworkflow_calljobs and there's no way to use a dedicated environment with reusable workflow secrets. Renaming the file so zizmor no longer scans it, and we no longer use this workflow until we have a real fix.